Merged
Conversation
For alignment with other Solid projects.
RubenVerborgh
commented
Apr 28, 2018
| "preversion": "npm test", | ||
| "postversion": "git push --follow-tags", | ||
| "prepublishOnly": "yarn build" | ||
| "prepare": "npm run build" |
Contributor
Author
There was a problem hiding this comment.
@timbl You'll like this: by using the prepare hook instead of prepublishOnly, we ensure that npm run build is always executed after npm install.
There was a problem hiding this comment.
And we now have consistency across the project in not using yarn, just npm. Looks good
timbl
reviewed
Apr 28, 2018
timbl
left a comment
timbl
left a comment
There was a problem hiding this comment.
Looks OK to me, from the half I followed
RubenVerborgh
commented
Apr 28, 2018
| } | ||
| const popupServer = server(childWindow, originOf(options.popupUri))( | ||
| popupAppRequestHandler(store, options, (session: session) => { | ||
| const popupServer = server(childWindow, originOf(options.popupUri || ''))( |
Contributor
Author
There was a problem hiding this comment.
Note: this was just to make Flow happy, which didn't detect the !options.popupUri above. The or never triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current development environment is broken because of underlying package updates, also leading to failures on Travis. This PR ensures that everything can be linted, transpiled, and tested again.